Your error is occuring when Vignettes are built. This happens when building the package, not checking which is why the error_on argument had no effect.
If your vignettes can't be built for whatever reason you can use devtools::check(vignettes = FALSE) to suppress building and checking vignettes.